From af7f70e60e364b551c2589dee5fb458a83fa0e7e Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Tue, 22 Nov 2016 23:46:00 +1100 Subject: flxdec: fix some warnings comparing unsigned < 0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit bf43f44fcfada5ec4a3ce60cb374340486fe9fac was comparing an unsigned expression to be < 0 which was always false. gstflxdec.c: In function ‘flx_decode_brun’: gstflxdec.c:322:33: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if ((glong) row - count < 0) { ^ gstflxdec.c:332:33: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if ((glong) row - count < 0) { ^ https://bugzilla.gnome.org/show_bug.cgi?id=774834 Index: gst-plugins-good0.10-0.10.31/gst/flx/gstflxdec.c =================================================================== --- gst-plugins-good0.10-0.10.31.orig/gst/flx/gstflxdec.c 2016-11-22 08:53:19.577997632 -0500 +++ gst-plugins-good0.10-0.10.31/gst/flx/gstflxdec.c 2016-11-22 08:53:19.569997540 -0500 @@ -341,7 +341,7 @@ if (count > 0x7f) { /* literal run */ count = 0x100 - count; - if ((glong) row - count < 0) { + if ((glong) row - (glong) count < 0) { GST_ERROR_OBJECT (flxdec, "Invalid BRUN packet detected."); return FALSE; } @@ -351,7 +351,7 @@ *dest++ = *data++; } else { - if ((glong) row - count < 0) { + if ((glong) row - (glong) count < 0) { GST_ERROR_OBJECT (flxdec, "Invalid BRUN packet detected."); return FALSE; }